Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rust): update rustc #13947

Merged
merged 3 commits into from
Jan 24, 2024
Merged

chore(rust): update rustc #13947

merged 3 commits into from
Jan 24, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jan 24, 2024 •
edited
Loading

Failing due to change in alignment. Found by @orlp.

stable:
[src/main.rs:2] std::mem::align_of::<u128>() = 8

nightly:
[src/main.rs:2] std::mem::align_of::<u128>() = 16

Had to roll a manual viewtype.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 24, 2024
@ritchie46 ritchie46 merged commit 1fc0568 into main Jan 24, 2024
18 checks passed
@ritchie46 ritchie46 deleted the dev branch January 24, 2024 15:29
@c-peters c-peters added the accepted Ready for implementation label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@universalmind303 universalmind303 Awaiting requested review from universalmind303

Assignees

@ritchie46 ritchie46

Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @c-peters